XCTest: update shebang line to name python3 instead of python generically. #441
Conversation
|
@swift-ci please test |
|
CC: @edymtt |
|
CC: @dduan |
|
@swift-ci please test macOS platform |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci test macos |
fischman-bcny
changed the title
|
@dduan @edymtt macOS CI failure seems unrelated to this PR. Is it possible to merge this to unblock swiftlang/swift-corelibs-foundation#4740 ? (I've tried & failed to repro the test failures on darwin; on my machine I see different unrelated failures with the xctest test subprocesses exiting -5 whereas CI has them exiting -4...) |
|
We need to update the python version here. |
|
@shahmishal I had done that in the first version of this PR (2009414) but that also failed CI. (happy to update this PR to be any of these) |
|
I think all of the files should use python3, as we no longer have python2 on the CI nodes. |
…cally. Motivated by [failure](https://ci.swift.org/job/swift-corelibs-foundation-PR-macOS/221/execution/node/43/log/) from swiftlang/swift-corelibs-foundation#4740 test runs, which ended with: ``` + /Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/swift-corelibs-xctest/build_script.py --swiftc=/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/swift-macosx-x86_64/bin/swiftc --build-dir=/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/xctest-macosx-x86_64 --foundation-build-dir=/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/foundation-macosx-x86_64 --swift-build-dir=/Users/ec2-user/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-main/build/Ninja-ReleaseAssert/swift-macosx-x86_64 --release env: python: No such file or directory ```
|
@shahmishal ok, done. |
|
@swift-ci test macOS |
|
@shahmishal We're back to the CI failing on unrelated issues. Since we know that the CI machines don't have a |
|
Same command that failed on CI succeeded on my machine: https://gist.githubusercontent.com/fischman-bcny/008a14e4a2afe42a2767dd97ec3cc636/raw/05c5125ba49133bc64e5bc4b0a029954f8f65e81/gistfile0.txt @shahmishal is there a way I can ssh into the CI machine to investigate its failures? Or any other suggestions for unblocking this PR? |
|
Closing this PR since swiftlang/swift#65958 merged. |
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce).
[5.8] Call python3 to execute XCTest's build_script.py A workaround for the fact that fixing this in XCTest's repository (swiftlang/swift-corelibs-xctest#441) is blocked on XCTest's CI being broken for unrelated reasons (and ones which I cannot reproduce). Risk: low, all other Python scripts in the `swift` and `swift-package-manager` repositories already include this change and use `python3` in both `main` and `release/5.9` branches. This specific change has been on the `main` and `release/5.9` branches for a while now. Original PRs: #65958 for `main` and #66415 for `release/5.9` Reviewed by: @compnerd, @al45tair, and @shahmishal Resolves: unblocks PRs on the `swift-corelibs-foundation` repository that build XCTest as a part of their CI jobs. Tests: N/A
Motivated by failure from swiftlang/swift-corelibs-foundation#4740 test runs, which ended with: