Skip to content

Escape CMAKE_Swift_FLAGS to preserve Windows path separators when running tests #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Escape CMAKE_Swift_FLAGS to preserve Windows path separators when running tests #435

merged 1 commit into from
Mar 31, 2023

Conversation

tristanlabelle
Copy link
Contributor

Swift flags can include paths, which lost their \ separators to CMake's escaping when running tests.

@compnerd
Copy link
Member

@swift-ci please test

@stmontgomery stmontgomery requested a review from compnerd March 29, 2023 14:57
@compnerd compnerd merged commit 3829a54 into swiftlang:main Mar 31, 2023
@tristanlabelle tristanlabelle deleted the escape-CMAKE_Swift_FLAGS branch March 31, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants