[Tests] Add regression tests for pull request #7 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the %t change a bit? Does this wind up putting output in the sources? Was this intended as part of this PR? |
|
@mike-ferris-apple Yup! Sorry for not being clear--this should be reviewed after #31. I explain the |
modocache
force-pushed
the
more-list-tests-xctassertequalswithaccuracy
branch
from
64612e3 to
010cd0c
Compare
|
@mike-ferris-apple Thanks for merging #31. I rebased to include #31, plus @briancroom's changes from #33. This is my output now: It seems like the test output has become a little jumbled. I'd like to investigate a bit more to see why this is the case -- this probably shouldn't be merged in the meantime. |
|
I merged #35, but now there's a conflict here. |
swiftlang#33 introduced another regression that was not fixed in 4944003: the total number of test runs was not being reported correctly--only the total number of failures. Fix the misreporting, as well as the incorrect verification in the `FailingTestSuite` functional test.
swiftlang#7 fixed a problem with XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.
modocache
force-pushed
the
more-list-tests-xctassertequalswithaccuracy
branch
from
010cd0c to
0143cfa
Compare
|
Oops, sorry! I noticed another error. I submitted a pull request for it: #38. This pull request should be merged after that one. |
mike-ferris
pushed a commit
that referenced
this pull request
Jan 13, 2016
…withaccuracy [Tests] Add regression tests for pull request #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 fixed a problem with
XCTAssertEqualsWithAccuracy. This test ensures that fix does not regress.