event: support workqueue monitoring on Windows #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables workqueue monitoring on Windows to allow for overcommitting threads if necessary. We use a combination of WCT (wait chain tracing) - to determine if there is an object being waited upon - and IO checking - to determine if there is pending IO - to identify threads which are executing workloads. If no threads are executing workloads, then we may be in a starvation state and will initialize new threads. This should fix the issue that has been previously reported with SPM hangs. This is non-portable and ideally we would have an alternative approach to tracking thread state, but this should at least unblock the current situation.
compnerd
force-pushed
the
overcommitted
branch
from
e358313 to
52f6e64
Compare
|
CC: @rokhinip |
|
@swift-ci please test |
compnerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables workqueue monitoring on Windows to allow for overcommitting
threads if necessary. We use a combination of WCT (wait chain tracing)
executing workloads. If no threads are executing workloads, then we may
be in a starvation state and will initialize new threads. This should
fix the issue that has been previously reported with SPM hangs.
This is non-portable and ideally we would have an alternative approach
to tracking thread state, but this should at least unblock the current
situation.