[build] Silence -Wvoid-pointer-to-int-cast
#538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libdispatch will fail to build with a newly introduced clang diagnostic `pointer-to-int-cast`. libdispatch converts a void pointer to a dispatch_invoke_flags_t (aka unsigned int) in a few places. Ideally we would not be doing this, but this solution at least gets libdispatch building again with a newer version of clang.
|
@swift-ci please test |
|
cc @compnerd mind looking at this when you get the chance? |
|
LGTM; @ktopley-apple, okay to merge? |
compnerd
approved these changes
Feb 28, 2020
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
[build] Silence `-Wvoid-pointer-to-int-cast` Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdispatch will fail to build with a newly introduced clang diagnostic
pointer-to-int-cast. libdispatch converts a void pointer to adispatch_invoke_flags_t (aka unsigned int) in a few places. Ideally we would not
be doing this, but this solution at least gets libdispatch building again
with a newer version of clang.