build: add exports targets #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
bring-out-your-targets
branch
from
e5f4b01 to
3a61429
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
bring-out-your-targets
branch
from
3a61429 to
a89af11
Compare
|
@swift-ci please test |
Now that we can build the Swift content as a library, we can do export targets. This enables us to have CMake determine more information about the target, track dependencies across projects, and manage the flags across the trees without the special variables to specify the source and build trees.
Make BlocksRuntime public rather than private since the public headers reference `Blocks.h` making the users dependent on BlocksRuntime, requiring the explicit link. This also enables the use of the export targets to automatically setup the include paths for users.
compnerd
force-pushed
the
bring-out-your-targets
branch
from
a89af11 to
c26f435
Compare
|
@swift-ci please test |
|
@ktopley-apple - okay to merge? |
ktopley-apple
approved these changes
Sep 30, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: add exports targets Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can build the Swift content as a library, we can do export
targets. This enables us to have CMake determine more information about
the target, track dependencies across projects, and manage the flags
across the trees without the special variables to specify the source and
build trees.