queue: use the default stack size on Windows #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows thread pool implementation is calling `_beginthreadex` with a stack size of 64 KB. This seems like a misunderstanding to me. In the pthread code, `_dispatch_mgr_root_queue_init` does call `pthread_attr_setstacksize` with a 64 KB size. However, this only applies to the pthread root queue manager, and pthread root queues are only supported on Apple platforms anyway. We can confirm that using the OS default stack size is the intended semantic by looking at the `dispatch_select` test, which expects to be able to stack-allocate a 500 KB buffer in an event handler. This test is failing on Windows because there is not enough stack space. We've also run into various related issues in Swift which only happen on Windows, and I suspect that this is just because the stack size isn't so small on other platforms.
|
@swift-ci please test |
ktopley-apple
approved these changes
Sep 23, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
queue: use the default stack size on Windows Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows thread pool implementation is calling
_beginthreadexwitha stack size of 64 KB. This seems like a misunderstanding to me. In the
pthread code,
_dispatch_mgr_root_queue_initdoes callpthread_attr_setstacksizewith a 64 KB size. However, this onlyapplies to the pthread root queue manager, and pthread root queues are
only supported on Apple platforms anyway.
We can confirm that using the OS default stack size is the intended
semantic by looking at the
dispatch_selecttest, which expects to beable to stack-allocate a 500 KB buffer in an event handler. This test is
failing on Windows because there is not enough stack space. We've also
run into various related issues in Swift which only happen on Windows,
and I suspect that this is just because the stack size isn't so small on
other platforms.