build: migrate to standard mechanism for testing #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@ktopley-apple how would you prefer to handle this? Fix the warning or silence these warnings (since it seems that dispatch currently does quite a bit of tweaking to the warning flags): |
I would fix the warning with a cast. |
compnerd
force-pushed
the
enable-testing
branch
from
ffbceeb to
573871e
Compare
|
@swift-ci please test |
Use `CTest` module rather than the custom `ENABLE_TESTING` option. The inclusion of `CTest` will default `BUILD_TESTING` to true, which preserves the existing behaviour.
compnerd
force-pushed
the
enable-testing
branch
from
573871e to
b1fc1ad
Compare
|
@swift-ci please test |
Preserve the const-ness of the string constants as identified by the newer compiler.
compnerd
force-pushed
the
enable-testing
branch
from
b1fc1ad to
46862df
Compare
|
@swift-ci please test |
|
@ktopley-apple - okay to merge? |
ktopley-apple
approved these changes
Sep 17, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: migrate to standard mechanism for testing Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CTestmodule rather than the customENABLE_TESTINGoption. Theinclusion of
CTestwill defaultBUILD_TESTINGto true, whichpreserves the existing behaviour.