Skip to content

Fix warnings (treated as errors) #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Fix warnings (treated as errors) #467

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd984c3
build: address -Werror,-Wcovered-switch-default error
compnerd Mar 26, 2019
54c2f0c
build: switch `-Wswitch-enum` to `-Wswitch`
compnerd Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: switch -Wswitch-enum to -Wswitch 
-Wswitch-enum requires all cases be spelt out in a switch, even in the
presence of a `default` case.  This along with
`-Wswitch-covered-default` means that `default` cannot be used in a
switch over an enumerated type and every case must be spelt.  Use
`-Wswitch` instead which allows the use of `default` labels.
  • Loading branch information
@compnerd
compnerd committed Mar 26, 2019
commit 54c2f0c4558be7edfed61fe397db0ef585a487eb
2 changes: 1 addition & 1 deletion cmake/modules/DispatchCompilerWarnings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ else()
add_compile_options(-Wsign-conversion)
add_compile_options(-Wstatic-in-inline)
add_compile_options(-Wsuper-class-method-mismatch)
add_compile_options(-Wswitch-enum)
add_compile_options(-Wswitch)
add_compile_options(-Wunguarded-availability)
add_compile_options(-Wunreachable-code)
add_compile_options(-Wunused)
Expand Down