Skip to content

Allow building on wider range of dependencies on Linux #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2018

Conversation

millenomi
Copy link
Contributor

This patch allows building libdispatch with a wider range of dependencies on Linux systems. This also removes references to ‘swift’ in paths if Swift is not enabled.

This patch allows building libdispatch with a wider range of dependencies on Linux systems. This also removes references to ‘swift’ in paths if Swift is not enabled.
@millenomi
Copy link
Contributor Author

@swift-ci Please test on Linux.

@MadCoder MadCoder requested a review from compnerd January 8, 2018 23:45
@MadCoder
Copy link
Contributor

MadCoder commented Jan 8, 2018

@compnerd if you can have a look at the build system part, I didn't spot anything weird, but you've worked more on CMake than I have ;)

thanks

@MadCoder MadCoder self-requested a review January 8, 2018 23:46
@MadCoder
Copy link
Contributor

MadCoder commented Jan 8, 2018

@swift-ci please test

@millenomi
Copy link
Contributor Author

https://ci.swift.org/job/swift-corelibs-libdispatch-PR-Linux/38/console

Interesting — looks like the error is in the LLVM support in CMake, so not patch-dependent?

@millenomi
Copy link
Contributor Author

Trying to reproduce locally.

@millenomi
Copy link
Contributor Author

@swift-ci Please clean test Linux.

@millenomi
Copy link
Contributor Author

@MadCoder Looks like this may need clean testing I can't trigger.

@parkera
Copy link
Contributor

parkera commented Jan 9, 2018

@shahmishal can you help us get a clean build going?

@shahmishal
Copy link
Member

This PR build was clean

[WS-CLEANUP] Deleting project workspace...

@millenomi
Copy link
Contributor Author

@shahmishal the failure looks unrelated to the patch, and we can't reproduce locally. Would you know where to look on this one?

@shahmishal
Copy link
Member

@shahmishal
Copy link
Member

@swift-ci test Linux

@millenomi
Copy link
Contributor Author

@compnerd Any comment before we push this?

@MadCoder MadCoder merged commit 8b72f76 into swiftlang:master Jan 11, 2018
ktopley-apple pushed a commit that referenced this pull request Dec 6, 2018
Allow building on wider range of dependencies on Linux

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants