-
Notifications
You must be signed in to change notification settings - Fork 469
Allow building on wider range of dependencies on Linux #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch allows building libdispatch with a wider range of dependencies on Linux systems. This also removes references to ‘swift’ in paths if Swift is not enabled.
@swift-ci Please test on Linux. |
@compnerd if you can have a look at the build system part, I didn't spot anything weird, but you've worked more on CMake than I have ;) thanks |
@swift-ci please test |
https://ci.swift.org/job/swift-corelibs-libdispatch-PR-Linux/38/console Interesting — looks like the error is in the LLVM support in CMake, so not patch-dependent? |
Trying to reproduce locally. |
@swift-ci Please clean test Linux. |
@MadCoder Looks like this may need clean testing I can't trigger. |
@shahmishal can you help us get a clean build going? |
This PR build was clean
|
@shahmishal the failure looks unrelated to the patch, and we can't reproduce locally. Would you know where to look on this one? |
This issue was introduced yesterday, and it has been fixed now. started: fixed: @swift-ci test |
@swift-ci test Linux |
@compnerd Any comment before we push this? |
Allow building on wider range of dependencies on Linux Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
This patch allows building libdispatch with a wider range of dependencies on Linux systems. This also removes references to ‘swift’ in paths if Swift is not enabled.