A few updates to enable building on Raspberry PI/Ubuntu 16.04 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCoder
suggested changes
Oct 24, 2017
src/source.c
Outdated
| @@ -2023,15 +2023,15 @@ static inline unsigned long | |||
| _dispatch_source_timer_data(dispatch_source_t ds, dispatch_unote_t du) | |||
| { | |||
| dispatch_timer_source_refs_t dr = du._dt; | |||
| unsigned long data, prev, clear_prev = 0; | |||
| unsigned long long data, prev, clear_prev = 0; | |||
|
This looks good, please squash the branch so that I can merge it. |
|
@swift-ci test |
MadCoder
approved these changes
Oct 25, 2017
|
Done, I think? Let me know if I didn't do that right. |
|
Nope it says 4 commits, should be just the one |
|
|
Okay, the 'git rebase -i origin master' provided just a single 'noop' entry. So I rebased like normal but used your pick/fixup instruction and it looks like that got it right. Sorry 'bout this. It's not your job to teach git. Appreciate it, though. |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
A few updates to enable building on Raspberry PI/Ubuntu 16.04 Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some compilation failures while building on the Raspberry PI Model 3. These issues were simply type conversion warnings that resulted in errors (due to -Werror in the compilation settings.)
There may be more related issues, but what is attached is the minimal set of changes required to get it to build for me.
My setup: Raspberry PI 3 Model B
My apologies for not providing the exact compilation error output. It would take hours to produce those errors. If they are needed, I can restart that process to do so.