Attempt to update for SE-0103 (@noescape by default)

[slavapestov]

No description provided.

[slavapestov]

@swift-ci Please test linux

[slavapestov]

@gparker42 Here's the second fix.

[slavapestov]

@swift-ci Please test linux

[slavapestov]

@swift-ci Please test linux

[slavapestov]

@gonzalolarralde Do you mind reviewing this? It builds upon your previous patch by properly marking all functions that previously were not @NoEscape as @escaping. Otherwise, almost everything becomes non-escaping, since that's the default.

[dgrove-oss]

does this need to go to the Swift3 branch as well?

[gonzalolarralde]

I think rescue could be @noescape. I can't see nothing keeping a reference to it.

[gonzalolarralde]

Hi @slavapestov, sorry my patch wasn't complete at that time. The changes in this PR makes total sense to me.

I took a look on the rest of the project and I found the following declarations that were @escaping (default, actually) before SE-0103 and that I think they should remain @escaping.

• dispatch_data_create(…, destructor) along with DispatchData.Deallocator.custom
• dispatch_queue_set_specific(…, destructor) (there's no associated typealias / parameter for this one, it's just being called with Queue._destructDispatchSpecificValue as parameter)

And finally,

• dispatch_source_set_event_handler(…, handler)
• dispatch_source_set_cancel_handler(…, handler)
• dispatch_source_set_registration_handler(…, handler)

along with

• DispatchSourceHandler
• _DispatchBlock

I can create a new PR with this changes if you want. Just let me know.

Thanks!