README - Added Toolchain section #136
Conversation
| @@ -24,3 +24,29 @@ Our first tasks for this project are: | |||
| 0. Incrementally add functionality back in. | |||
|
|
|||
| Some C headers and sources (e.g. `Availability.h`, `Block.h`, and the libclosure `runtime.c`) are similar to ones embedded into the CoreFoundation part of [swift-corelibs-foundation](http://github.com/apple/swift-corelibs-foundation). We should figure out a mechanism to share these instead of duplicating them across projects. | |||
|
|
|||
| ## Toolchain | |||
| To add libdispatch to the toolchain in Linux, you need to add libdispatch and install-libdispatch lines to ./swift/utils/build-presets.ini under `[preset: buildbot_linux]` section. Also to make the build run faster, you can comment the test lines. After those updates the section would be as following: | |||
There was a problem hiding this comment.
to the Swift toolchain in Linux (libdispatch can be built outside of swift too, so please be more precise).
|
|
I actually got this info from @seabaylea page in github: |
|
I'm not disputing that, but since I never build for linux or almost, I'd rather have someone who does review, that's the point of the review process :) |
|
Got back from vacation today; will dryrun instructions by tomorrow. At first glance they look like they will work. However, do we want this level of detail in README.md? The INSTALL file has similar (and more detailed) information about building a Swift toolchain that includes libdispatch using |
|
It is ok to have this info in INSTALL and point to it from README.md however can we change INSTALL file to be INSTALL.md (mark down format) just like README.md ? Sent from my iPhone
|
|
I agree this should live in INSTALL |
|
@MadCoder: any objection to having @amraboelela include changing INSTALL to INSTALL.md when the pull request is updated? |
|
nope, fine with me |
|
Does that mean I have to do the change and then make another pull request? Sent from my iPhone
|
|
Yeah, I agree that this fits better in INSTALL, which should become INSTALL.md. In fact, the whole document could do with refactoring/cleanup. In terms of the content, I would remove the information on commenting out the tests, and just state that (currently) you have to add @amraboelela You can either do the work in your existing branch and squash your commits, or create a new PR. |
|
Done. Please check. |
|
@seabaylea please review, and if it feels ok @amraboelela please squash in a single commit |
|
I was trying to do the squash but I failed :) |
|
Here's my "goto cheatsheet" for squashing commits: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit |
|
Created new pr #138 |
No description provided.