Make POSIXError use POSIXErrorCode from Swift Stdlib
#933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nit: Can you rebase to squash the merge commits? |
|
@CodaFi Done. |
|
@swift-ci test |
|
Looks good, but the tests didn't run. Let me try: @swift-ci please test |
|
@swift-ci please test |
|
|
|
|
|
CodaFi
reviewed
Apr 7, 2017
Foundation/NSError.swift
Outdated
| @@ -10,6 +10,11 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #if os(OSX) || os(iOS) | |||
There was a problem hiding this comment.
Rebased and changed
Darwin or Glibc Make `POSIXError` use POSIXErrorCode from platform library
|
@swift-ci please test |
|
@colemancda Can you rebase this and try again? |
|
This pull request has gone stale, and the build fails. If the build can be fixed and rebased onto master, then it can be re-submitted. |
|
Fixed in swiftlang/swift@8157194 |
|
Rework in #2113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now POSIXError is broken on Linux, with Foundation defining
POSIXError.Codethat is valid for Darwin, not Linux. The Swift Standard Library already has a properly defined and unit testedPOSIXErrorCodethat is platform specific for Darwin and Linux. Foundation should use thisenumand not define an invalid duplicate.