Foundation API Conformance Update: Errors

[itaiferber]

Changes

• NSCocoaError → CocoaError
• Reimplement top-level error values in terms of consistent definitions
• Import new error types (RecoverableError, LocalizedError) from overlay
• Import URL errors and POSIX errors from overlay
• Import error bridging from overlay
• Update error code usage throughout project

[itaiferber]

@swift-ci Please test

[itaiferber]

@DougGregor Any thoughts/concerns about this change? I ported the NSError changes almost wholesale from the overlay (sans features requiring silgen and forms of bridging which are not present on Linux).

[itaiferber]

Hmm. Looks like a serious compiler crash. Can't replicate on Linux myself, but looking into it.

[itaiferber]

Perhaps there was a timing issue involved here. I want to see if re-testing makes any sort of difference. @swift-ci Please test

[itaiferber]

(For reference, the failure is still available to view here for the time being while CI re-runs)

[DougGregor]

_getEmbeddedNSError isn't actually used when we don't have an Objective-C runtime, so you can remove this bit.

[itaiferber]

Figured, but wasn't 100% sure (about this and about _GenericObjCError); will remove.

[itaiferber]

I doubt this will fix the CI build error, but it's worth a shot.

[itaiferber]

@swift-ci Please test

[DougGregor]

The compiler crash looks like we're trying to do some bridging without checking for ObjC interop.

[DougGregor]

For reference, the rest of this PR looks good to me. Thank you!

[itaiferber]

@DougGregor Figured; trying to diagnose, though haven't been able to reproduce on Linux yet, which will make testing expensive if I have to push to CI every time.

Thanks for the help!

[itaiferber]

Pushed a change that might avoid the compilation crash we see here.

[itaiferber]

@swift-ci Please test

[itaiferber]

Looks like that fixed the hashValue failure point; the only other location is isEqual. Hopefully this change will correct things.

[itaiferber]

@swift-ci Please test

[itaiferber]

Perfect. Avoiding the (missing) bridging by overriding NSObject methods avoids the silgen issue.