Fix OpenBSD clause. #5160
Merged
Fix OpenBSD clause. #5160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD, as the comment string in _CFPosixSpawnFileActionsChdir says, doesn't have posix_spawn_file_actions_addchdir. Therefore, don't link against it; just return ENOSYS like other similarly situated platforms do.
|
@swift-ci please test |
jmschonfeld
approved these changes
Jan 21, 2025
|
I think the Linux ci failure is unrelated, please re-run on my behalf. |
|
@swift-ci please test Linux platform |
|
Please merge on my behalf if there are no other blockers, thank you! |
jakepetroules
added a commit
that referenced
this pull request
Mar 22, 2025
…tate The refactoring in #5160 moved a comment around such that it appeared as if QNX supports this function - it does not. Clarify the situation.
| @@ -2300,8 +2304,6 @@ CF_EXPORT int _CFPosixSpawnFileActionsChdir(_CFPosixSpawnFileActionsRef file_act | |||
| // Standardized posix_spawn_file_actions_addchdir version (POSIX.1-2024, June 2024) available in: | |||
| // - Solaris 11.4 (August 2018) | |||
| // - NetBSD 10.0 (March 2024) | |||
| // Currently missing as of: | |||
| // - OpenBSD 7.5 (April 2024) | |||
There was a problem hiding this comment.
Just a heads up, this adjustment of the comment made it look confusingly like QNX 8 supports posix_spawn_file_actions_addchdir (it does not). Got confused when I came back to look... fixing in #5192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD, as the comment string in _CFPosixSpawnFileActionsChdir says, doesn't have posix_spawn_file_actions_addchdir. Therefore, don't link against it; just return ENOSYS like other similarly situated platforms do.