Update to use dynamic replacement for _NSNumberInitializer #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Aug 1, 2024
|
@swift-ci please test Linux platform |
jmschonfeld
added a commit
to jmschonfeld/swift-corelibs-foundation
that referenced
this pull request
Aug 2, 2024
This was referenced Aug 2, 2024
jmschonfeld
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In swiftlang/swift-foundation#756 we transitioned the
FoundationEssentials-->FoundationInternationalizationupcalls from_typeByNameto@_dynamicReplacementfunctions to avoid accidentally looking up types from the toolchain in local builds. In that PR, I also added adynamicfunction forFoundationto override for itsNSNumberinitializer. This PR implements that dynamic replacement so that we can remove the final_typeByNamelookup inFoundationEssentials