Include CFBase.h in CoreFoundation_Prefix.h #4979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
approved these changes
Jun 17, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-corelibs-foundation
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a Windows build failure I encountered when building a Windows toolchain with this branch. We use
CF_EXPORTwithin a windows-only code path ofCoreFoundation_Prefix.handCF_EXPORTis defined inCFBase.h.CFBase.his included from this file on themainbranch, so this PR restores that include which should correct this build failure.The project still builds successfully for linux with this change