Cherry pick: Make Date, DateComponents and DateInterval Sendable #4833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `Date`, `DateComponents` and `DateInterval` `Sendable`
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@compnerd @shahmishal I think the macOS CI is broken. It was already broken for the 5.9 release itself and we merged over it in my previous PR as well: #4789 |
ktoso
approved these changes
Oct 2, 2023
|
Approved but can you give the PR a better title? :) |
FranzBusch
changed the title
|
Seeing something similar on other branches, I think that it might be wisest to go ahead and merge this for 5.9.1 (macOS builds of swift-corelibs-foundation are not for release purposes). |
compnerd
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.