Change equalityOracle to compare based on values rather than indices #4743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the `checkHashable` is mistakenly using an `equalityOracle` that merely compares the two index arguments themselves, rather than the underlying values at those index arguments. And so the comparison will always pass, regardless of whether the underlying values were different. This appears to be a problem throughout the test cases, but this PR only fixes the check in TestDate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the
checkHashableis mistakenly using anequalityOraclethat merely compares the two index arguments themselves, rather than the underlying values at those index arguments. And so the comparison will always pass, regardless of whether the underlying values were different.This appears to be a problem throughout the test cases, but this PR only fixes the check in TestDate.