Skip to content

Include accuracy for point and size transformation checks #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcprux
Copy link

The TestAffineTransform.testInversion case was failing for me on macOS 13.3 with:

TestAffineTransform.swift:692: error: -[SkipFoundationTests.TestAffineTransform testInversion] : XCTAssertEqual failed: ("(10.0, 10.000000000000002)") is not equal to ("(9.999999999999998, 10.000000000000002)") - Expected NSAffineTransform to match AffineTransform's point-accepting transform(_:)

TestAffineTransform.swift:692: error: -[SkipFoundationTests.TestAffineTransform testInversion] : XCTAssertEqual failed: ("(10.000000000000004, 10.000000000000002)") is not equal to ("(10.000000000000002, 10.000000000000002)") - Expected NSAffineTransform to match AffineTransform's size-accepting transform(_:)

This PR resolves it by including the accuracy in the XCTAssertEqual for the CGPoint and CGSize instances.

@MaxDesiatov
Copy link
Contributor

@swift-ci test

@MaxDesiatov MaxDesiatov requested review from parkera and kperryua April 24, 2023 19:01
@compnerd
Copy link
Member

compnerd commented May 3, 2023

@swift-ci please test macOS platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants