Move the size check to be the first thing checked in CFAllocator functions #4641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
CFBase
branch
2 times, most recently
from
64f41f1 to
e744ada
Compare
parkera
approved these changes
Oct 13, 2022
|
Does this really save us 'a lot of work'? |
|
It saves some work @parkera |
AZero13
force-pushed
the
CFBase
branch
2 times, most recently
from
ec41427 to
7182370
Compare
|
Any update on this @parkera |
parkera
approved these changes
Mar 31, 2023
|
@swift-ci test |
AZero13
changed the title
|
@parkera Can we try this one more time? |
|
@swift-ci test |
|
@parkera I apologize. I did not account for the malloc_zone tests. That has been fixed. Can we try one more time? |
…tions This saves us a lot of work is size is 0
|
@swift-ci test |
|
@parkera this passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves us a lot of work is size is 0