[NSCalendar] match Darwin API #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Darwin .currentCalendar() is now imported as .current()
|
@swift-ci please test |
|
I'd merge if the tests pass. @shahmishal, this looks like another instance of non-Apple committers being unable to trigger CI. I experienced the same issue last night, see: swiftlang/swift-corelibs-xctest#106 (comment). |
|
@swift-ci please test |
|
@modocache I am puzzled that still no one has merged this pr. please test again and merge. |
|
Sorry, @damuellen! I don't get a notification when Swift CI passes, which means I sometimes forget to check back 😭 Could you rebase your changes? It looks like it can no longer be merged. Sorry!! |
|
@modocache I tried to rebase, but it didn't work, I will close this pr now, and create new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin .currentCalendar() is now imported as .current()