Foundation: support _getFileSystemRepresentation on Windows
#2658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Seems that it is hanging on the Facebook donated host. sigh time to make further tweaks |
compnerd
force-pushed
the
win32-filesystem
branch
from
eac6cfc to
0e5130d
Compare
|
@swift-ci please test Linux platform |
Update the `_getFileSystemRepresentation` helper to return a UTF-16 Windows style path. This enables us to properly model the file system representation of the path and the URL representation of the path.
compnerd
force-pushed
the
win32-filesystem
branch
from
0e5130d to
5d9b008
Compare
|
@swift-ci please test Linux platform |
|
@swift-ci test linux |
|
new failure count: 56, old failure count: 65 |
|
I'm going to merge this for now, its improving the current state, though I will have more fixes to follow on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
_getFileSystemRepresentationhelper to return a UTF-16Windows style path. This enables us to properly model the file system
representation of the path and the URL representation of the path.