Skip to content

Use "Asia/Jerusalem" instead of "Israel" #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

gmittert
Copy link
Contributor

@gmittert gmittert commented Sep 16, 2019

  • Israel is deprecated in favor of Asia/Jerusalem
  • Brazil/East is deprecated in favor of America/Sao_Paulo
  • Asia/Chongqing is an alias for Asia/Shanghai

@gmittert
Copy link
Contributor Author

@swift-ci please test and merge

@gmittert gmittert force-pushed the UseAsia/Jerusalem branch 2 times, most recently from 0ed3067 to 443086f Compare September 17, 2019 00:11
@gmittert
Copy link
Contributor Author

@swift-ci please test and merge

@compnerd
Copy link
Member

I think that we should verify with @millenomi that it is acceptable to move to the modern spelling here rather than the deprecated spelling.

@compnerd
Copy link
Member

@swift-ci please test

@compnerd compnerd requested a review from millenomi September 17, 2019 16:25
@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@compnerd compnerd requested a review from parkera September 20, 2019 16:14
@compnerd
Copy link
Member

@millenomi @parkera is the deprecated name being used intentionally?

gmittert and others added 2 commits January 20, 2020 17:14
- Israel is deprecated in favor of Asia/Jerusalem
- Brazil/East is deprecated in favor of America/Sao_Paulo
- Asia/Chongqing is an alias for Asia/Shanghai
@compnerd
Copy link
Member

@swift-ci please test

@compnerd compnerd merged commit 307df29 into swiftlang:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants