Support Swift 4.2 Hashable #2115
Conversation
|
@spevans Can you test this please? |
| @@ -137,9 +137,15 @@ public struct Date : ReferenceConvertible, Comparable, Equatable { | |||
| */ | |||
| public static let distantPast = Date(timeIntervalSinceReferenceDate: -63114076800.0) | |||
|
|
|||
| #if swift(>=4.2) | |||
There was a problem hiding this comment.
The swift version check should not be needed as there is a branch per version.
| public func hash(into hasher: inout Hasher) { | ||
| unit.hash(into: &hasher) | ||
| value.hash(into: &hasher) | ||
| } |
There was a problem hiding this comment.
I dont see this method on Darwin's Foundation (unless its in the latest beta?)
There was a problem hiding this comment.
If you don't implement func hash(into hasher: inout Hasher) it uses hashValue as a fallback implementation, which on Darwin is just the NSObject hash.
|
Could you add a testcase just calling the method for each of the types are modifying please |
|
cc @lorentey who was already working on this, or similar. |
|
I suggest to hold this; this is somewhat trickier than it looks, and it has to be synced with the Foundation overlay. In swiftlang/swift#23832, I submitted a draft PR for the overlay parts; I'm preparing a similar PR for corelibs-foundation, too. |
|
Update: My corelibs-foundation PR is up at #2118. |
|
@colemancda thank you for the contribution — I'm gonna close this because it has been superseded by #2118. |
|
Ok, if this is done better somewhere else, that's great. |
Updates implementation of
Hashablein Foundation types to properly support Swift 4.2 and 5.