Skip to content

[5.0] Import Data and DataProtocol from the overlay (and correct some incorrect CFData and NSData usages) #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

[5.0] Import Data and DataProtocol from the overlay (and correct some incorrect CFData and NSData usages) #1853

merged 1 commit into from
Jan 28, 2019

Conversation

millenomi
Copy link
Contributor

This releases this PR to Swift 5.0 (cherry picked from commit 4a25565).

@phausler @millenomi
Import Data and DataProtocol from the overlay (and correct some incor…
c3a5096 
…rect CFData and NSData usages) (#1834)

* Import Data and DataProtocol from the overlay (and correct some incorrect CFData and NSData usages)

* Linux build fixes for Data and DataProtocol correcting nullability and inline/objc decorators

(cherry picked from commit 4a25565)
@millenomi
Copy link
Contributor Author

@swift-ci please test and merge

@millenomi millenomi mentioned this pull request Jan 26, 2019
Closed
@millenomi
Copy link
Contributor Author

@swift-ci please test and merge

@millenomi
Copy link
Contributor Author

@swift-ci please test macOS

@millenomi
Copy link
Contributor Author

The failures are infrastructure failures. Tests pass.

Merging.

@millenomi millenomi merged commit 7f7edfe into swiftlang:swift-5.0-branch Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millenomi @phausler