Import Data and DataProtocol from the overlay (and correct some incorrect CFData and NSData usages) #1834
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2018 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| //===--- DataProtocol -----------------------------------------------------===// | ||
|
|
||
| extension Array: DataProtocol where Element == UInt8 { | ||
| public var regions: CollectionOfOne<Array<UInt8>> { | ||
| return CollectionOfOne(self) | ||
| } | ||
| } | ||
|
|
||
| extension ArraySlice: DataProtocol where Element == UInt8 { | ||
| public var regions: CollectionOfOne<ArraySlice<UInt8>> { | ||
| return CollectionOfOne(self) | ||
| } | ||
| } | ||
|
|
||
| extension ContiguousArray: DataProtocol where Element == UInt8 { | ||
| public var regions: CollectionOfOne<ContiguousArray<UInt8>> { | ||
| return CollectionOfOne(self) | ||
| } | ||
| } | ||
|
|
||
| // FIXME: This currently crashes compilation in the Late Inliner. | ||
| // extension CollectionOfOne : DataProtocol where Element == UInt8 { | ||
| // public typealias Regions = CollectionOfOne<Data> | ||
| // | ||
| // public var regions: CollectionOfOne<Data> { | ||
| // return CollectionOfOne<Data>(Data(self)) | ||
| // } | ||
| // } | ||
|
|
||
| extension EmptyCollection : DataProtocol where Element == UInt8 { | ||
| public var regions: EmptyCollection<Data> { | ||
| return EmptyCollection<Data>() | ||
| } | ||
| } | ||
|
|
||
| extension Repeated: DataProtocol where Element == UInt8 { | ||
| public typealias Regions = Repeated<Data> | ||
|
|
||
| public var regions: Repeated<Data> { | ||
| guard self.count > 0 else { return repeatElement(Data(), count: 0) } | ||
| return repeatElement(Data(CollectionOfOne(self.first!)), count: self.count) | ||
| } | ||
| } | ||
|
|
||
| //===--- MutableDataProtocol ----------------------------------------------===// | ||
|
|
||
| extension Array: MutableDataProtocol where Element == UInt8 { } | ||
|
|
||
| extension ContiguousArray: MutableDataProtocol where Element == UInt8 { } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sorted this section: hopefully that does not pose any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it does, it will be immediately apparent. The places where things were out of order were due to the compiler requiring the interfaces to be processed earlier.