Fix Xcode build #1818
Closed
Fix Xcode build #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ikesyo
reviewed
Jan 14, 2019
| @@ -35,7 +35,7 @@ private func getTestData() -> [Any]? { | |||
| XCTFail("Unable to deserialize property list data") | |||
| return nil | |||
| } | |||
| guard let parsingTests = testRoot[kURLTestParsingTestsKey] as? [Any] else { | |||
| guard let parsingTests = testRoot?[kURLTestParsingTestsKey] as? [Any] else { | |||
There was a problem hiding this comment.
This is related to SE-0230.
guard let testRoot = try? PropertyListSerialization.propertyList(from: data, options: [], format: nil) as? [String : Any] else {This would break Linux builds which is built using Swift 5 mode.
|
I think |
|
#1824 has been merged. |
This was referenced Jan 16, 2019
|
Closing this in favor of #1829. Thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using latest master (60651e2) and same toolchain that this commits points to (swift-DEVELOPMENT-SNAPSHOT-2019-01-10-a) I'm unable to build using Xcode unless I make the following changes.
Not sure if those fixes goes through PR's too.