Import the new inline Data implementation and DataProtocol from the overlay #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
karwa
reviewed
Dec 20, 2018
Foundation/DataProtocol.swift
Outdated
| } | ||
|
|
||
| public func lastRange<D: DataProtocol>(of data: D) -> Range<Index>? { | ||
| return self.firstRange(of: data, in: self.startIndex ..< self.endIndex) |
There was a problem hiding this comment.
Should be lastRange.
See the 5.0 cherry-pick at swiftlang/swift#21292. We should sync that updated version to the overlay on master, too.
There was a problem hiding this comment.
yea we definitely shouldn't have master be different for Data and swift-5.0
karwa
reviewed
Dec 20, 2018
Foundation/Data.swift
Outdated
| count = range.upperBound | ||
| } | ||
| Swift.withUnsafeMutableBytes(of: &bytes) { rawBuffer in | ||
| bzero(rawBuffer.baseAddress?.advanced(by: range.lowerBound), range.upperBound - range.lowerBound) |
There was a problem hiding this comment.
Similarly, this was replaced with memset. bzero isn't portable.
…he swift version in the xcode projects and correct some failures in TestURL by updating to 4.2
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
This is out of date and supplanted by the other merge I landed. |
|
#1834 was the one that landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings Data in sync with the overlay changes for the new inline revamp.