Skip to content

compatibility with ObjCBool #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

compatibility with ObjCBool #1226

wants to merge 1 commit into from

Conversation

weissi
Copy link
Contributor

@weissi weissi commented Sep 19, 2017 •
edited
Loading

@weissi weissi requested a review from parkera September 19, 2017 11:09
@weissi
Copy link
Contributor Author

weissi commented Sep 19, 2017

CC @Lukasa

@ianpartridge
Copy link
Contributor

#1223 🙂

@spevans
Copy link
Contributor

spevans commented Sep 19, 2017

I think this is actually a better solution than mine in #1223, see my comment about using the struct from the stdlib.

@ianpartridge
Copy link
Contributor

Hi @weissi - I think the merging of #1223 supercedes this. Please reopen this PR if you disagree for any reason!

@weissi
Copy link
Contributor Author

weissi commented Sep 20, 2017

@ianpartridge indeed, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera Awaiting requested review from parkera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weissi @ianpartridge @spevans