NotificationCenter should us NSNotification.Name per docs #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to https://developer.apple.com/documentation/foundation/notificationcenter/1407263-removeobserver it should be |
|
addObserver(...) says the same in docs, but in source it’s using `Notification.Name` (not that that makes this PR correct)
https://developer.apple.com/documentation/foundation/notificationcenter/1411723-addobserver
…Sent from my iPhone
On 9. Sep 2017, at 18:51, Ian Partridge ***@***.***> wrote:
According to https://developer.apple.com/documentation/foundation/notificationcenter/1407263-removeobserver it should be NSNotification.Name?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
It would be great to fix up these incompatibilities. Do you want to do that in this PR? Or should we close it? |
|
Just to clarify, you mean to change them both back to |
|
Yes. It looks like |
glenna
force-pushed
the
fix/nsnotification_to_notification
branch
from
4b88061 to
a47cc7e
Compare
|
@swift-ci please test |
|
@ianpartridge got a bit busy, but it's done now. i'll edit the PR title/description so the merge commit will have a relevant message |
glenna
changed the title
ianpartridge
changed the title
|
Thanks! |
ianpartridge
pushed a commit
to ianpartridge/swift-corelibs-foundation
that referenced
this pull request
Oct 9, 2017
…#1208) NotificationCenter should use NSNotification.Name per docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Apple docs,
addObserverandpostuseNSNotification.Name