Skip to content

Fix excluded required source file in cmark-gfm #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix excluded required source file in cmark-gfm #60

merged 1 commit into from
Jun 7, 2023

Conversation

@luispadron
Copy link

@luispadron luispadron commented Jun 7, 2023 •
edited
Loading

Fixes an excluded source file in cmark-gfm that is required by utf8.c.

Running swift build on swift-cmark succeeds. This succeeds because clang defaults to looking in the source file's directory when resolving includes. The clang invocation is:

/Applications/Xcode-14.2.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -fobjc-arc -target x86_64-apple-macosx10.13 -g -O0 -DSWIFT_PACKAGE=1 -DDEBUG=1 -fblocks -index-store-path /Users/chuck/code/apple/swift-cmark/.build/x86_64-apple-macosx/debug/index/store -fmodules -fmodule-name=cmark_gfm -I /Users/chuck/code/apple/swift-cmark/src/include -fmodules-cache-path=/Users/chuck/code/apple/swift-cmark/.build/x86_64-apple-macosx/debug/ModuleCache -isysroot /Applications/Xcode-14.2.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -F /Applications/Xcode-14.2.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks -fPIC -MD -MT dependencies -MF /Users/chuck/code/apple/swift-cmark/.build/x86_64-apple-macosx/debug/cmark_gfm.build/utf8.c.d -c /Users/chuck/code/apple/swift-cmark/src/utf8.c -o /Users/chuck/code/apple/swift-cmark/.build/x86_64-apple-macosx/debug/cmark_gfm.build/utf8.c.

Reported in: cgrindel/rules_swift_package_manager#400

@luispadron luispadron mentioned this pull request Jun 7, 2023
Closed
cgrindel
cgrindel reviewed Jun 7, 2023
View reviewed changes
@luispadron
Fix excluded required source file in cmark-gfm
6f064e6 
Fixes an excluded source file in `cmark-gfm` that is required by [utf8.c](https://github.com/apple/swift-cmark/blob/gfm/src/utf8.c#L237).
@luispadron luispadron marked this pull request as ready for review June 7, 2023 20:29
@luispadron luispadron requested a review from cgrindel June 7, 2023 20:30
QuietMisdreavus
QuietMisdreavus approved these changes Jun 7, 2023
View reviewed changes
Copy link

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@QuietMisdreavus QuietMisdreavus merged commit b1c49eb into swiftlang:gfm Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

+1 more reviewer

@cgrindel cgrindel cgrindel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luispadron @cgrindel @QuietMisdreavus