Skip to content

App Sandbox build setting ends up in iOS signed app #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

App Sandbox build setting ends up in iOS signed app #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Sources/SWBCore/SigningSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public protocol PlatformSigningContext
func shouldPassEntitlementsFileContentToCodeSign() -> Bool

func requiresEntitlements(_ scope: MacroEvaluationScope, hasProfile: Bool, productFileType: FileTypeSpec) -> Bool

func supportsAppSandboxAndHardenedRuntime() -> Bool
}

extension PlatformSigningContext
Expand Down Expand Up @@ -58,12 +60,19 @@ extension PlatformSigningContext
{
return hasProfile || scope.evaluate(BuiltinMacros.ENTITLEMENTS_REQUIRED)
}

@_spi(Testing) public func supportsAppSandboxAndHardenedRuntime() -> Bool {
return false
}
}


/// Provides behavior for code signing for the macOS platform.
@_spi(Testing) public struct MacSigningContext: PlatformSigningContext
{
@_spi(Testing) public func supportsAppSandboxAndHardenedRuntime() -> Bool {
return true
}
}


Expand Down
5 changes: 1 addition & 4 deletions Sources/SWBCore/SpecImplementations/Tools/ProductPackaging.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,12 @@ public final class ProductPackagingToolSpec : GenericCommandLineToolSpec, SpecId
entitlementsDictionary["com.apple.security.get-task-allow"] = nil
}

let isAppSandboxEnabled = cbc.scope.evaluate(BuiltinMacros.ENABLE_APP_SANDBOX)
let isHardenedRuntimeEnabled = cbc.scope.evaluate(BuiltinMacros.ENABLE_HARDENED_RUNTIME)

// rdar://142845111 (Turn on `AppSandboxConflictingValuesEmitsWarning` by default)
if SWBFeatureFlag.enableAppSandboxConflictingValuesEmitsWarning.value {
EntitlementConflictDiagnosticEmitter.checkForConflicts(cbc, delegate, entitlementsDictionary: entitlementsDictionary, entitlementsPath: codeSignEntitlementsInput?.absolutePath)
}

if isAppSandboxEnabled || isHardenedRuntimeEnabled {
if cbc.producer.platform?.signingContext.supportsAppSandboxAndHardenedRuntime() == true {
// Inject entitlements that are settable via build settings.
// This is only supported when App Sandbox or Hardened Runtime is enabled.
for (buildSetting, entitlementPrefix) in Self.sandboxFileAccessSettingsAndEntitlements {
Expand Down
67 changes: 13 additions & 54 deletions Tests/SWBBuildSystemTests/EntitlementsBuildOperationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,24 +238,24 @@ fileprivate struct EntitlementsBuildOperationTests: CoreBasedTests {
}
}

/// Test that the `ProcessProductEntitlementsTaskAction` does not embed build settings based entitlements that are dependent on App Sandbox being enabled, when App Sandbox is disabled.
@Test(.requireSDKs(.macOS))
func macOSAppSandboxEnabledEntitlementsWithSandboxDisabled() async throws {
/// Test that the `ProcessProductEntitlementsTaskAction` does not embed build settings that only apply to macOS.
@Test(.requireSDKs(.iOS))
func iOSAppSandboxAndHardnedRuntimeBuildSettingEnabled() async throws {
try await withTemporaryDirectory { tmpDirPath async throws -> Void in
let testWorkspace = entitlementsTestWorkspace(
sourceRoot: tmpDirPath,
buildSettings: [
"PRODUCT_NAME": "$(TARGET_NAME)",
"INFOPLIST_FILE": "Info.plist",
"CODE_SIGN_IDENTITY": "-",
"RUNTIME_EXCEPTION_ALLOW_DYLD_ENVIRONMENT_VARIABLES": "NO",
"RUNTIME_EXCEPTION_ALLOW_JIT": "NO",
"RUNTIME_EXCEPTION_ALLOW_UNSIGNED_EXECUTABLE_MEMORY": "NO",
"AUTOMATION_APPLE_EVENTS": "NO",
"RUNTIME_EXCEPTION_DEBUGGING_TOOL": "NO",
"RUNTIME_EXCEPTION_DISABLE_EXECUTABLE_PAGE_PROTECTION": "NO",
"RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION": "NO",
"ENABLE_APP_SANDBOX": "NO",
"AD_HOC_CODE_SIGNING_ALLOWED": "YES",
"RUNTIME_EXCEPTION_ALLOW_DYLD_ENVIRONMENT_VARIABLES": "YES",
"RUNTIME_EXCEPTION_ALLOW_JIT": "YES",
"RUNTIME_EXCEPTION_ALLOW_UNSIGNED_EXECUTABLE_MEMORY": "YES",
"AUTOMATION_APPLE_EVENTS": "YES",
"RUNTIME_EXCEPTION_DEBUGGING_TOOL": "YES",
"RUNTIME_EXCEPTION_DISABLE_EXECUTABLE_PAGE_PROTECTION": "YES",
"RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION": "YES",
"ENABLE_APP_SANDBOX": "YES",
"ENABLE_FILE_ACCESS_DOWNLOADS_FOLDER": "readwrite",
"ENABLE_FILE_ACCESS_PICTURE_FOLDER": "readonly",
"ENABLE_FILE_ACCESS_MUSIC_FOLDER": "readwrite",
Expand All @@ -271,7 +271,7 @@ fileprivate struct EntitlementsBuildOperationTests: CoreBasedTests {
"ENABLE_RESOURCE_ACCESS_PHOTO_LIBRARY": "YES",
"ENABLE_RESOURCE_ACCESS_USB": "YES",
"ENABLE_RESOURCE_ACCESS_PRINTING": "YES",
"SDKROOT": "macosx"
"SDKROOT": "iphoneos"
]
)

Expand Down Expand Up @@ -481,47 +481,6 @@ fileprivate struct EntitlementsBuildOperationTests: CoreBasedTests {
}
}

/// Test that the `ProcessProductEntitlementsTaskAction` does not embed build settings based entitlements that are dependent on Hardened Runtime being enabled, when Hardened Runtime is disabled.
@Test(.requireSDKs(.macOS))
func macOSHardenedRuntimeEnabledEntitlementsWithHardenedRuntimeDisabled() async throws {
try await withTemporaryDirectory { tmpDirPath async throws -> Void in
let testWorkspace = entitlementsTestWorkspace(
sourceRoot: tmpDirPath,
buildSettings: [
"PRODUCT_NAME": "$(TARGET_NAME)",
"INFOPLIST_FILE": "Info.plist",
"CODE_SIGN_IDENTITY": "-",
"ENABLE_HARDENED_RUNTIME": "NO",
"RUNTIME_EXCEPTION_ALLOW_DYLD_ENVIRONMENT_VARIABLES": "YES",
"RUNTIME_EXCEPTION_ALLOW_JIT": "YES",
"RUNTIME_EXCEPTION_ALLOW_UNSIGNED_EXECUTABLE_MEMORY": "YES",
"AUTOMATION_APPLE_EVENTS": "YES",
"RUNTIME_EXCEPTION_DEBUGGING_TOOL": "YES",
"RUNTIME_EXCEPTION_DISABLE_EXECUTABLE_PAGE_PROTECTION": "YES",
"RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION": "YES",
"ENABLE_FILE_ACCESS_DOWNLOADS_FOLDER": "readwrite",
"ENABLE_FILE_ACCESS_PICTURE_FOLDER": "readonly",
"ENABLE_FILE_ACCESS_MUSIC_FOLDER": "readwrite",
"ENABLE_FILE_ACCESS_MOVIES_FOLDER": "readonly",
"ENABLE_INCOMING_NETWORK_CONNECTIONS": "YES",
"ENABLE_OUTGOING_NETWORK_CONNECTIONS": "YES",
"ENABLE_RESOURCE_ACCESS_AUDIO_INPUT": "YES",
"ENABLE_RESOURCE_ACCESS_BLUETOOTH": "YES",
"ENABLE_RESOURCE_ACCESS_CALENDARS": "YES",
"ENABLE_RESOURCE_ACCESS_CAMERA": "YES",
"ENABLE_RESOURCE_ACCESS_CONTACTS": "YES",
"ENABLE_RESOURCE_ACCESS_LOCATION": "YES",
"ENABLE_RESOURCE_ACCESS_PHOTO_LIBRARY": "YES",
"SDKROOT": "macosx"
]
)

try await buildTestBinaryAndValidateEntitlements(testWorkspace: testWorkspace, expectedEntitlements: [
"com.apple.application-identifier": "$(AppIdentifierPrefix)$(CFBundleIdentifier)",
])
}
}

@Test(.requireSDKs(.iOS))
func simulatorEntitlementsSections() async throws {
try await withTemporaryDirectory { tmpDirPath in
Expand Down