Fix linker swiftmodule registration in incremental builds #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
artemcm
reviewed
Apr 15, 2025
owenv
force-pushed
the
owenv/module-registration-fix
branch
from
6750c3b to
b341959
Compare
|
@swift-ci test |
artemcm
reviewed
Apr 15, 2025
rdar://149248232
owenv
force-pushed
the
owenv/module-registration-fix
branch
from
b341959 to
9b74adc
Compare
|
@swift-ci test |
artemcm
approved these changes
Apr 15, 2025
mirza-garibovic
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we always enumerate the entire module graph looking for swift modules to register, as opposed to the subset of modules we built.
rdar://149248232