Remove variant name from explicit precompile rule info to allow deduping #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Mar 12, 2025
neonichu
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Change LGTM.
The test seems a bit fragile since where that will be one or two task scheduled is at the mercy of the compiler implementation to produce the same module task or not. Fine with me for now but I am not sure if we decide to stick with the current module flags for swift asan.
|
@cachemeifyoucan in this test instead of using ASAN I'm building a variant with identical compiler args, which should ensure that even if the compiler changes the test is still sound |
cachemeifyoucan
approved these changes
Mar 12, 2025
aciidgh
approved these changes
Mar 12, 2025
|
@swift-ci test |
Not all variants depend on incompatible modules. Remove the variant name from the rule info so that identical tasks are deduplicated properly and cannot race.
owenv
force-pushed
the
owenv/ebm-variant
branch
from
8d875e6 to
eef2dc6
Compare
|
@swift-ci test |
|
@swift-ci test Linux |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all variants depend on incompatible modules. Remove the variant name from the rule info so that identical tasks are deduplicated properly and cannot race.