Update build progress message to include build action count#1397
Open
bripeticca wants to merge 2 commits into
Open
Update build progress message to include build action count#1397bripeticca wants to merge 2 commits into
bripeticca wants to merge 2 commits into
Conversation
Add extra properties to BuildOperationProgressUpdated that track the number of commands to execute + completed, as well as a condensed status message that omits the fraction usually appended to the status property
| public let numPossibleMaxExecutedCommands: Int? | ||
|
|
||
| /// A condensed status message. | ||
| public let condensedStatusMessage: String? |
Collaborator
There was a problem hiding this comment.
What's the idea behind having statusMessage and condensedStatusMessage?
Contributor
Author
There was a problem hiding this comment.
The current statusMessage contains the <completed> / <to be executed commands> fraction, which we don't want on the SwiftPM side. I wanted to make an additive change to this model since there are other possible consumers that could rely on the current derivation of the statusMessage, but at the same time we need something different for SwiftPM to construct its own progress logs.
Contributor
Author
|
@swift-ci test |
bripeticca
requested review from
aciidgh,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extra properties to BuildOperationProgressUpdated that track the number of commands to execute + completed, as well as a condensed status message that omits the fraction usually appended to the status property.