Update client capabilities to LSP 3.17 #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
Contributor
|
@swift-ci test windows |
bnbarham
approved these changes
Jul 22, 2023
| public struct ShowDocument: Hashable, Codable { | ||
| /// The client has support for the show document | ||
| /// request. | ||
| public var support: Bool? |
Contributor
There was a problem hiding this comment.
This isn't optional in the spec. Do we usually just leave as optional and treat nil as false regardless?
ahoppen
force-pushed
the
ahoppen/update-client-capabilities
branch
from
360ef2d to
654a188
Compare
ahoppen
force-pushed
the
ahoppen/update-client-capabilities
branch
from
654a188 to
fa35a39
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, I only updated server capabilities and not client capabilities in #671.