[5.8] Add back -no-toolchain-stdlib-rpath when installing sourcekit-lsp on linux #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #715
Explanation: Pull #597 incorrectly removed this, as it's still needed on ELF platforms.
This was fine in 5.7.3, but will regress in 5.8 without this pull:
Note the incorrect
/home/build-user/...
runpath in the 5.8 snapshot, which could be a security issue.Scope: Only affects the runpath for the sourcekit-lsp executable on linux
SR Issue: None
Risk: None, simply lowers security risk
Testing: The CI was run when this was merged into trunk, including a full toolchain build.
Reviewer: @ahoppen
@airspeedswift, would be good to get this regression corrected before the 5.8 release. I will add an integration test in the coming weeks so that these runpath regressions don't happen again.