Fix issue that caused background indexing to be disabled when sourcekit-lsp is launched without options
#2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kit-lsp` is launched without options When launching sourcekit-lsp without any command-line arguments, we would set `backgroundIndexing = false` in the options. Unless the user overwrites this somehow, this means that background indexing is disabled. This is not an issue in VS Code, because it explicitly enables background indexing in the initialization request but for all other editors this means that background indexing was likely disabled by default. Simply remove that line since `backgroundIndexing` defaults to `true` by now anyway.
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 27, 2025
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching sourcekit-lsp without any command-line arguments, we would set
backgroundIndexing = falsein the options. Unless the user overwrites this somehow, this means that background indexing is disabled.This is not an issue in VS Code, because it explicitly enables background indexing in the initialization request but for all other editors this means that background indexing was likely disabled by default.
Simply remove that line since
backgroundIndexingdefaults totrueby now anyway.I’ll open a follow-up PR to fix this kind of issue for other settings, defaulting to
nilinstead of empty arrays but I think those don’t have real-world impact because the default value in the command-line arguments and inSourceKitLSPOptionsline up.