Interpret the working directories in compile_commands.json relative to the directory that contains compile_commands.json
#2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
ahoppen
force-pushed
the
relative-compile-commands
branch
from
315c8cc to
20d809c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
relative-compile-commands
branch
from
20d809c to
f5ec279
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
… to the directory that contains `compile_commands.json` Fixes swiftlang#1908
ahoppen
force-pushed
the
relative-compile-commands
branch
from
f5ec279 to
8db31ac
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Oct 28, 2025
| } | ||
|
|
||
| /// A file URL representing `directory`. If `directory` is relative, it's interpreted relative to | ||
| /// `compileCommandsDirectory`, the directory that contains the |
bnbarham
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908