Skip to content

Log to stdout on non-Windows platforms #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Log to stdout on non-Windows platforms #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Sources/SKLogging/NonDarwinLogging.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,17 @@ actor LogHandlerActor {
/// The handler that is called to log a message from `NonDarwinLogger` unless `overrideLogHandler` is set on the logger.
@LogHandlerActor
var logHandler: @Sendable (String) async -> Void = { message in
// Print to stdout. When using the sourcekit-lsp binary, we will have stdout redirected to stderr, so it ends up
// logging to stderr. During test execution, we log to stdout, which is generally better handled than logging to
// stderr by XCTest (for some reason logging to stderr will hang test execution when running tests in parallel).
print(message + "\n")
// On Windows, print to stdout by default because printing to stderr causes XCTest execution to deadlock when running
// tests in parallel on Windows.
// On all other platforms, print to stderr by default because otherwise XCTest will interleave log output with its own
// output, causing hard-to-read-output.
// When running SourceKit-LSP as a process (ie. in the real world), stdout is redirected to stderr, so the two are
// equivalent.
#if os(Windows)
print(message + "\r\n")
#else
fputs(message + "\n", stderr)
#endif
}

/// The queue on which we log messages.
Expand Down