Skip to content

Conversation

@lokesh-tr
Copy link
Contributor

@lokesh-tr lokesh-tr commented Aug 19, 2024

This brings the "Expand Macro" Code Action out of the experimental feature flag.

You can now remove the following from your swift settings:

"swift.sourcekit-lsp.serverArguments": [
    "--experimental-feature", "show-macro-expansions"
],

Expansion of Swift Macros in Visual Studio Code - Google Summer Of Code 2024
@lokesh-tr @ahoppen @adam-fowler

@lokesh-tr lokesh-tr requested a review from ahoppen as a code owner August 19, 2024 06:38
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s ship it 🚀

@ahoppen
Copy link
Member

ahoppen commented Aug 19, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge August 19, 2024 21:53
auto-merge was automatically disabled August 20, 2024 01:37

Head branch was pushed to by a user without write access

@lokesh-tr lokesh-tr force-pushed the remove-experimental-feature-flag-for-macro-expansions branch from bb1d60c to a616fc1 Compare August 20, 2024 01:37
@lokesh-tr
Copy link
Contributor Author

@ahoppen The test failed since I forgot to run swift-format, my bad. I ran it now, can you please trigger the CI once again?

@ahoppen
Copy link
Member

ahoppen commented Aug 20, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge August 20, 2024 04:47
@ahoppen
Copy link
Member

ahoppen commented Aug 20, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit b45d975 into swiftlang:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants