Skip to content

[6.0] Add option to allow SourceKit-LSP to prepare a target without lazy type checking #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 25, 2024

  • Explanation: Adds an option to the SourceKit-LSP configuration file to run background preparation without lazy type checking. This is intended as a workaround for users using the experimental background indexing should they run into compiler crashes due to lazy type checking, which hasn’t been thoroughly tested in practice yet.
  • Scope: Background indexing
  • Risk: Low, only adds a new configuration option
  • Testing: Added test case
  • Issue: rdar://130333458
  • Reviewer: @bnbarham

@ahoppen ahoppen requested a review from bnbarham July 25, 2024 23:08
@ahoppen
Copy link
Member Author

ahoppen commented Jul 25, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 26, 2024 00:14
@ahoppen ahoppen force-pushed the 6.0/no-lazy-prepartion branch from 7f8d3d0 to 1780d06 Compare July 26, 2024 00:16
@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 480bb0c into swiftlang:release/6.0 Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants