Skip to content

Make SourceKit-LSP build without warnings #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 25, 2024

Fixes all build warnings in SourceKit-LSP so that it builds without any issues using recent Swift development snapshots (swift-DEVELOPMENT-SNAPSHOT-2024-07-22-a and swift-6.0-DEVELOPMENT-SNAPSHOT-2024-07-24-a)

Fixes all build warnings in SourceKit-LSP so that it builds without any issues using recent Swift development snapshots (`swift-DEVELOPMENT-SNAPSHOT-2024-07-22-a` and `swift-6.0-DEVELOPMENT-SNAPSHOT-2024-07-24-a`)
@ahoppen ahoppen requested a review from bnbarham July 25, 2024 22:45
@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 26, 2024 00:14
@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2024

swiftlang/indexstore-db#218

@swift-ci Please test Linux

@ahoppen
Copy link
Member Author

ahoppen commented Jul 26, 2024

swiftlang/indexstore-db#218

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 0493221 into swiftlang:main Jul 26, 2024
2 of 3 checks passed
@benrimmington
Copy link

@ahoppen Linux builds are failing, I think due to the removal of @preconcurrency import in this pull request.

/home/build-user/sourcekit-lsp/Sources/SourceKitLSP/Rename.swift:625:40: error: type 'Symbol' does not conform to the 'Sendable' protocol
 623 |         )
 624 |       } else {
 625 |         logger.debug("Not translating \(definitionSymbol) to Swift because it is not referenced from Swift")
     |                                        `- error: type 'Symbol' does not conform to the 'Sendable' protocol
 626 |         swiftName = nil
 627 |       }

/home/build-user/indexstore-db/Sources/IndexStoreDB/Symbol.swift:55:15: note: struct 'Symbol' does not conform to the 'Sendable' protocol
 53 | }
 54 | 
 55 | public struct Symbol: Hashable {
    |               `- note: struct 'Symbol' does not conform to the 'Sendable' protocol
 56 | 
 57 |   public var usr: String

/home/build-user/sourcekit-lsp/Sources/SourceKitLSP/Rename.swift:13:1: warning: add '@preconcurrency' to treat 'Sendable'-related errors from module 'IndexStoreDB' as warnings
  11 | //===----------------------------------------------------------------------===//
  12 | 
  13 | import IndexStoreDB
     | `- warning: add '@preconcurrency' to treat 'Sendable'-related errors from module 'IndexStoreDB' as warnings
  14 | import LanguageServerProtocol
  15 | import SKLogging

@bnbarham
Copy link
Contributor

swiftlang/indexstore-db#218 wasn't merged simultaneously, it's in now so this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants