Adopt package access level
#1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
package-access-level
branch
from
56b7bca to
d0c158d
Compare
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
Change a l public declarations to the `package` access level, accept for: - The `LanguageServerProtocol` module - The `BuildServerProtocol` module - `InProcessClient.InProcessSourceKitLSPClient` - `LanguageServerProtocolJSONRPC` (I would like to create a more ergonomic API for this like `InProcessSourceKitLSPClient` in the future, but for now, we’ll leave it public) Unfortunately, our pattern of marking functions as `@_spi(Testing) public` no longer works with the `package` access level because declarations at the `package` access level cannot be marked as SPI. I have decided to just mark these functions as `package`. Alternatives would be: - Add an underscore to these functions, like we did for functions exposed for testing before the introduction of `SPI` - Use `@testable` import in the test targets and mark the methods as `internal` Resolves swiftlang#1315 rdar://128295618
ahoppen
force-pushed
the
package-access-level
branch
from
d0c158d to
2877675
Compare
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test macOS |
Member
Author
|
@swift-ci Please test Linux |
Member
Author
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a l public declarations to the
packageaccess level, accept for:LanguageServerProtocolmoduleBuildServerProtocolmoduleInProcessClient.InProcessSourceKitLSPClientLanguageServerProtocolJSONRPC(I would like to create a more ergonomic API for this likeInProcessSourceKitLSPClientin the future, but for now, we’ll leave it public)Unfortunately, our pattern of marking functions as
@_spi(Testing) publicno longer works with thepackageaccess level because declarations at thepackageaccess level cannot be marked as SPI. I have decided to just mark these functions aspackage. Alternatives would be:SPI@testableimport in the test targets and mark the methods asinternalResolves #1315
rdar://128295618