Skip to content

Add TriggerReindexRequest to builtinRequests #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

plemarquand
Copy link
Contributor

TriggerReindexRequest was missing from the list of builtinRequests, which caused the LSP to respond with a methodNotFound error when it recieved a workspace/triggerReindex request.

`TriggerReindexRequest` was missing from the list of builtinRequests,
which caused the LSP to respond with a methodNotFound error when it
recieved a `workspace/triggerReindex` request.
@plemarquand plemarquand requested a review from ahoppen as a code owner July 10, 2024 15:58
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Jul 10, 2024
Adds a command to trigger a re-indexing of the open project. Should only
be needed when background indexing is enabled and it gets out of sync.
While that is a bug, this can act as a temporary workaround.

Blocked By: swiftlang/sourcekit-lsp#1561
Issue: swiftlang#939
@plemarquand plemarquand changed the title Add TriggerReindexRequest to buildinRequests Add TriggerReindexRequest to builtinRequests Jul 11, 2024
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you! Could you also create a PR to release/6.0?

@ahoppen
Copy link
Member

ahoppen commented Jul 15, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 15, 2024 09:18
@ahoppen ahoppen merged commit 007d2cf into swiftlang:main Jul 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants