Skip to content

Make background indexing a proper option in SourceKitLSPOptions #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 28, 2024

This allows us to flip the default in the future more easily. It also allows users to disable background indexing when it’s enabled by default.

rdar://130280855

@ahoppen ahoppen requested review from bnbarham and hamishknight June 28, 2024 08:23
This allows us to flip the default in the future more easily. It also allows users to disable background indexing when it’s enabled by default.

rdar://130280855
@ahoppen ahoppen force-pushed the background-indexing-configuration-option branch from 64f1c54 to d8e0fff Compare June 28, 2024 08:23
@ahoppen
Copy link
Member Author

ahoppen commented Jun 28, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 6b88cfe into swiftlang:main Jun 28, 2024
3 checks passed
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this pull request Jun 28, 2024
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this pull request Jun 28, 2024
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this pull request Jun 28, 2024
ahoppen added a commit that referenced this pull request Jun 28, 2024
Fix a compilation issue caused by #1533 and #1524 racing
lokesh-tr pushed a commit to lokesh-tr/sourcekit-lsp that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants