Send SIGKILL to swift-frontend indexing processes
#1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 21, 2024
Contributor
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
Yeah we really ought to fix swift-frontend to respect SIGINT
Comment on lines
368
to
370
| // than 2 minutes in practice, so this indicates that the compiler has entered a loop and we probably won't make any | ||
| // progress here. We will try indexing the file again when it is edited or when the project is re-opened. | ||
| // 2 minutes have been chosen arbitrarily. |
Contributor
There was a problem hiding this comment.
Should this comment be updated/moved?
ahoppen
force-pushed
the
fix-index-cancellation
branch
2 times, most recently
from
cce2912 to
6e3fdc7
Compare
We were sending `SIGINT` to `swift-frontend` processes if they didn’t terminate after 2 minutes. However, `swift-frontend` doesn’t listen to `SIGINT`. If a task running `waitUntilExitStoppingProcessOnTaskCancellation` is cancelled and the process doesn’t terminate on a `SIGINT` after 2 seconds, kill it. rdar://130103147
ahoppen
force-pushed
the
fix-index-cancellation
branch
from
6e3fdc7 to
2ba180b
Compare
Member
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sending
SIGINTtoswift-frontendprocesses if they didn’t terminate after 2 minutes. However,swift-frontenddoesn’t listen toSIGINT.If a task running
waitUntilExitStoppingProcessOnTaskCancellationis cancelled and the process doesn’t terminate on aSIGINTafter 2 seconds, kill it.rdar://130103147