[build-script] Add installation support for sourcekit-lsp #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoked with the `install` action, build-script-helper.py will rsync the produced sourcekit-lsp to the toolchain's bin directory. On Linux, we add an extra relative rpath to find the swift corelibs (unfotunately we currently have no way to remove the absolute rpath; the same is true for all other swift-built binaries in the toolchain). On macOS, we replace the rpath.
Swift-build was logging some extra information to stdout, causing incorrect calculation of the bin dir.
Handy for local development if you don't want to test with swift's full build.
|
@swift-ci please test |
|
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoked with the
installaction, build-script-helper.py will rsync the produced sourcekit-lsp to the toolchain's bin directory. On Linux, we add an extra relative rpath to find the swift corelibs (unfotunately we currently have no way to remove the absolute rpath; the same is true for all other swift-built binaries in the toolchain). On macOS, we replace the rpath.